On 01.06.21 06:01, Amit Kapila wrote:
But, won't that be costly in cases where we have errors in the processing of very large transactions? Subscription has to process all the data before it gets an error. I think we can even imagine this feature to be extended to use commitLSN as a skip candidate in which case we can even avoid getting the data of that transaction from the publisher. So if this information is persistent, the user can even set the skip identifier after the restart before the publisher can send all the data.
At least in current practice, skipping parts of the logical replication stream on the subscriber is a rare, emergency-level operation when something that shouldn't have happened happened. So it doesn't really matter how costly it is. It's not going to be more costly than the error happening in the first place. All you'd need is one shared memory slot per subscription to store a xid to skip.
We will also want some proper conflict handling at some point. But I think what is being discussed here is meant to be a repair tool, not a policy tool, and I'm afraid it might get over-engineered.
