On Fri, May 28, 2021 at 10:53 PM Etsuro Fujita <etsuro.fuj...@gmail.com> wrote: > On Fri, May 28, 2021 at 5:29 PM Kyotaro Horiguchi > <horikyota....@gmail.com> wrote: > > The patch drops some "= NULL" (initial) initializations when > > nasyncplans == 0. AFAICS makeNode() fills the returned memory with > > zeroes but I'm not sure it is our convention to omit the > > intializations. > > I’m not sure, but I think we omit it in some cases; for example, we > don’t set as_valid_subplans to NULL explicitly in ExecInitAppend(), if > do_exec_prune=true.
Ok, I think it would be a good thing to initialize the pointers/variables to NULL/zero explicitly, so I updated the patch as such. Barring objections, I'll get the patch committed in a few days. Best regards, Etsuro Fujita
fix-rescan-of-async-appends-v2.patch
Description: Binary data
