On Sun, May 30, 2021 at 6:14 AM Andreas Karlsson <andr...@proxel.se> wrote:
> On 4/26/21 12:20 AM, Andres Freund wrote: > > It seems pretty clear that this should be changed to be something more > > like > > > > [...] > > > > with initGISTstate allocating based on > > IndexRelationGetNumberOfKeyAttributes() instead of using a constant. > > > > And then subsequently change GIST_COL_STATE to embed the > > FunctionCallInfo, rather than initializiing them on the stack for every > > call. > > > > > > I'm not planning on doing this work, but I thought it's sensible to send > > to the list anyway. > > I did the first part since it seemed easy enough and an obvious win for > all workloads. > > Andreas > Hi, Minor comment: + /* Collations to pass to the support functions */ + Oid supportCollation; Collations -> Collation The field used to be an array. Now it is one Oid. Cheers
