On Wed, May 26, 2021 at 5:28 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, May 26, 2021 at 1:47 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > On Wed, May 26, 2021 at 11:53 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > > > On Wed, May 26, 2021 at 11:19 AM Amit Kapila <amit.kapil...@gmail.com> > > > wrote: > > > > > > > > > > > > > I searched and didn't find any similar existing tests. Can we think of > > > > any other way to test this code path? We already have one copy test in > > > > toast.sql, isn't it possible to write a similar test here? > > > > > > I will check that and let you know. > > > > I have followed this approach to write the test. > > > > The changes look good to me. I have made minor modifications in the > comments, see attached. Let me know what do you think?
Your modification looks good to me. Thanks! -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
