Greetings,
* Justin Pryzby (pry...@telsasoft.com) wrote:
> This patch adds hits/misses/dirtied, but explain says
> hit/read/dirtied/written.
>
> Should it say "read" instead of "misses" ?
>
> src/backend/access/heap/vacuumlazy.c:
> _("buffer usage: %lld hits, %lld misses, %lld dirtied\n"),
Errr, the analyze readahead patch set didn't add the above use of
'misses', that's been around for an age or more. For giggles, I hunted
it back to be this 2011 commit: 9d3b50244357ef4c4e3b6e01f91de599077179c8
As for the "misses" usage which was actually added by the patch here:
src/backend/commands/analyze.c: appendStringInfo(&buf, _("buffer usage:
%lld hits, %lld misses, %lld dirtied\n"),
That was specifically done to match the 'vacuumlazy.c' usage of 'misses'
above.
As for which to use, I don't have any particular dog in that fight, but
I do think we should be consistent between how VACUUM reports this
information and how ANALYZE does.
Thanks!
Stephen
signature.asc
Description: PGP signature
