On Sat, Mar 20, 2021 at 12:16:27PM +1300, Thomas Munro wrote:
> > > +     {
> > > +             {"recovery_init_sync_method", PGC_POSTMASTER, 
> > > ERROR_HANDLING_OPTIONS,
> > > +                     gettext_noop("Sets the method for synchronizing the 
> > > data directory before crash recovery."),
> > > +             },

Is there any reason why this can't be PGC_SIGHUP ?
(Same as restart_after_crash, remove_temp_files_after_crash)

As neat as it'd be, I am not expecting the recovery process to reload the
configuration and finish fast if I send it HUP.

While I'm looking, it's not clear why this needs to be PGC_POSTMASTER.
data_sync_retry - but see b3a156858

This one isn't documented as requiring a restart:
max_logical_replication_workers.

ignore_invalid_pages could probably be SIGHUP, but it's intended to be used as
a commandline option, not in a config file.

-- 
Justin


Reply via email to