On Tue, May 25, 2021 at 10:14 AM Justin Pryzby <pry...@telsasoft.com> wrote:
Some comment. +#define BKPIMAGE_COMPRESS_METHOD1 0x04 /* bits to encode compression method */ +#define BKPIMAGE_COMPRESS_METHOD2 0x08 /* 0=none, 1=pglz, 2=zlib */ Instead of using METHOD1, METHOD2, can we use the direct method name, that will look cleaner? + unsigned long len_l = COMPRESS_BUFSIZE; + int ret; + ret = compress2((Bytef*)dest, &len_l, (Bytef*)source, orig_len, 1); compress2((Bytef*)dest -> compress2((Bytef *) dest diff --git a/src/test/recovery/t/011_crash_recovery.pl b/src/test/recovery/t/011_crash_recovery.pl index a26e99500b..2e7e3db639 100644 --- a/src/test/recovery/t/011_crash_recovery.pl +++ b/src/test/recovery/t/011_crash_recovery.pl @@ -14,7 +14,7 @@ use Config; plan tests => 3; my $node = get_new_node('primary'); -$node->init(allows_streaming => 1); +$node->init(); $node->start; How this change is relevant? +#ifdef USE_LZ4 + case WAL_COMPRESSION_LZ4: + len = LZ4_compress_fast(source, dest, orig_len, COMPRESS_BUFSIZE, 1); + if (len == 0) + len = -1; + break; +#endif If we are passing acceleration as 1, then we can directly use LZ4_compress_default, it is the same as LZ4_compress_fast with acceleration=1. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com