On Tue, 25 May 2021 at 11:16 AM, Michael Paquier <mich...@paquier.xyz> wrote:
> On Mon, May 24, 2021 at 02:46:11PM +0530, Dilip Kumar wrote: > > Like this. > > if (TupleDescAttr(newTupDesc, i)->attisdropped) > > isnull[i] = true; > > else > > tup_values[i] = values[i]; > > That would work. Your suggestion, as I understood it first, makes the > code simpler by not using tup_values at all as the set of values[] is > filled when the values and nulls are extracted. So I have gone with > this simplification, and applied the patch (moved a bit the comments > while on it). Perfect. That looks much better. >
