Hello Aleksander,
- better software engineering
- similar speed (slightly slower)
- better statistical quality
- quite small state
- soundness
Personally, I think your patch is great.
Thanks for having a look!
Speaking of the speed I believe we should consider the performance of
the entire DBMS in typical scenarios, not the performance of the single
procedure.
Sure. I tested a worst-case pgbench script with only "\set i random(1,
100000000)" on a loop, the slowdown was a few percents (IFAICR < 5%).
I'm pretty sure in these terms the impact of your patch is neglectable
now, and almost certainly beneficial in the long term because of better
randomness.
While reviewing your patch I noticed that you missed test_integerset.c.
Here is an updated patch.
Indeed. Thanks for the catch & the v2 patch!
--
Fabien.
