On 2021/05/17 18:58, Bharath Rupireddy wrote:
Hi, It looks like the values such as '123.456', '789.123' '100$%$#$#', '9,223,372,' are accepted and treated as valid integers for postgres_fdw options batch_size and fetch_size. Whereas this is not the case with fdw_startup_cost and fdw_tuple_cost options for which an error is thrown. Attaching a patch to fix that.
This looks an improvement. But one issue is that the restore of dump file taken by pg_dump from v13 may fail for v14 with this patch if it contains invalid setting of fetch_size, e.g., "fetch_size '123.456'". OTOH, since batch_size was added in v14, it has no such issue. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
