On Sun, May 16, 2021 at 11:17:46PM -0400, Tom Lane wrote:
> Bruce Momjian <br...@momjian.us> writes:
> > OK, I moved the entry into 'data types', and listed two entries instead
> > of one:
>       
> >     <para>
> >     Allow extensions and built-in data types to implement subscripting (Tom 
> > Lane)
> >     </para>
> 
> Better, but Dmitry Dolgov gets the credit not me.

OK, fixed.

> >     <para>
> >     Previously subscript handling was hard-coded into the server and
> >     was difficult to add to date types.
> >     </para>
> >     </listitem>
> 
> "Difficult"?  I don't think it was possible at all.  Perhaps

I used difficult to mean you had to hack the server code to enable it,
but your sentence below is better since it highlights usage beyond
arrays.


>       Previously subscript handling was hard-coded into the server,
>       so that subscripting could only be applied to array types.
>       This change allows subscript notation to be used to extract
>       or assign portions of a value of any type for which the concept
>       makes sense.
> 
> >     JSONB subscripting can be used to extract from and assign to
> >     JSONB documents.
> 
> Perhaps "extract and assign to portions of JSONB documents" or
> something like that?

OK, updated text for both items:

        <listitem>
        <!--
        Author: Tom Lane <t...@sss.pgh.pa.us>
        2020-12-09 [c7aba7c14] Support subscripting of arbitrary types, not 
only arrays
        -->
        
        <para>
        Allow extensions and built-in data types to implement subscripting 
(Dmitry Dolgov)
        </para>
        
        <para>
        Previously subscript handling was hard-coded into the server,
        so that subscripting could only be applied to array types.  This
        change allows subscript notation to be used to extract or assign
        portions of a value of any type for which the concept makes sense.
        </para>
        </listitem>
        
        <listitem>
        <!--
        Author: Alexander Korotkov <akorot...@postgresql.org>
        2021-01-31 [676887a3b] Implementation of subscripting for jsonb
        Author: Alexander Korotkov <akorot...@postgresql.org>
        2021-01-31 [81fcc72e6] Filling array gaps during jsonb subscripting
        Author: Alexander Korotkov <akorot...@postgresql.org>
        2021-01-31 [aa6e46daf] Throw error when assigning jsonb scalar instead 
of a com
        -->
        
        <para>
        Allow subscripting of JSONB (Dmitry Dolgov)
        </para>
        
        <para>
        JSONB subscripting can be used to extract and assign to portions
        of JSONB documents.
        </para>
        </listitem>

-- 
  Bruce Momjian  <br...@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.



Reply via email to