Robert Haas <robertmh...@gmail.com> writes:
> On Thu, May 13, 2021 at 2:22 PM Tom Lane <t...@sss.pgh.pa.us> wrote:
>> Meh. I'm not convinced that that position ought to apply to amvalidate.
> I am still of the opinion that we ought to apply it across the board,
> for consistency.
The main reason I'm concerned about applying that rule to amvalidate
is that then how do you know what's actually an error case?
As a hardly-irrelevant counterexample, we have a whole bunch of
regression tests that do something like
SELECT ...
WHERE NOT amvalidate(oid);
Every one of those is silently and dangerously wrong if amvalidate
might sometimes return null.
regards, tom lane
