On Tue, May 11, 2021 at 2:47 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2021-May-10, vignesh C wrote: > > > That sounds fine to me, Attached v6 patch which has the changes for the > > same. > > What about defining a function (maybe a static inline function in > defrem.h) that is marked noreturn and receives the DefElem and > optionally pstate, and throws the error? I think that would avoid the > patch's need to have half a dozen copies of the "duplicate_error:" label > and ereport stanza.
+1 to have a static inline function which just reports the error. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com