On Mon, May 10, 2021 at 05:28:24PM +0900, Masahiko Sawada wrote: > On Mon, May 10, 2021 at 3:03 PM Bruce Momjian <br...@momjian.us> wrote: > > > > I have committed the first draft of the PG 14 release notes. You can > > see the most current build of them here: > > > > https://momjian.us/pgsql_docs/release-14.html > > Thank you! > > > Add system view pg_stat_replication_slots to report replication slot > > activity (Sawada Masahiko, Amit Kapila) > > > > Function pg_stat_reset_replication_slot() resets slot statistics. THIS IS > > LOGICAL ONLY, BUT NO "LOGICAL" IN THE NAME? > > IIUC pg_stat_replication_slots view supports only logical slot for > now. But we might have it show also physical slot in the future. I'm > fine with the current view name and description but someone might want > to use "logical replication slot" instead of just "replication slot".
OK, I was just confirming we are happy with the name. > > > IS "ACTIVITY" THE RIGHT WORD? > > The doc says "The pg_stat_replication_slots view will contain one row > per logical replication slot, showing statistics about its usage.". So > we can say "... to report replication slot statistics about its > usage". OK, I think I prefer "activity" so will just keep that. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
