On Tue, May 4, 2021 at 2:31 PM Andres Freund <and...@anarazel.de> wrote: > > Hi, > > On 2021-05-04 09:29:42 +1000, Peter Smith wrote: > > While reviewing some logical replication code I stumbled across a > > variable usage that looks suspicious to me. > > > Note that the AlterSubscription_refresh function (unlike other > > functions in the subscriptioncmds.c) is using the global variable > > "wrconn" instead of a local stack variable of the same name. I was > > unable to think of any good reason why it would be deliberately doing > > this, so my guess is that it is simply an accidental mistake that has > > gone unnoticed because the compiler was silently equally happy just > > using the global var. > > > Apparently, this is not causing any reported problems because it seems > > like the code has been this way for ~4 years [1]. > > This sounded vaguely familiar. After a bit of searching I found that's > because I debugged a crash related to it: > https://www.postgresql.org/message-id/20201111215820.qihhrz7fayu6myfi%40alap3.anarazel.de >
Oh! No wonder it sounded familiar. It looks like I've just re-discovered the identical problem 5 months after your post. ------ Kind Regards, Peter Smith. Fujitsu Australia
