On Fri, Apr 30, 2021 at 5:55 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > After more thought, it seems to me that we should use txn->size here > regardless of the top transaction or subtransaction since we're > iterating changes associated with a transaction that is either the top > transaction or a subtransaction. Otherwise, I think if some > subtransactions are not serialized, we will end up adding bytes > including those subtransactions during iterating other serialized > subtransactions. Whereas in ReorderBufferProcessTXN() we should use > txn->total_txn since txn is always the top transaction. I've attached > another patch to do this. >
LGTM. I have slightly edited the comments in the attached. I'll push this early next week unless there are more comments. -- With Regards, Amit Kapila.
use_total_size_v6.patch
Description: Binary data
