On Fri, Apr 09, 2021 at 10:50:53AM +0900, Michael Paquier wrote: > - {"track_commit_timestamp", PGC_POSTMASTER, REPLICATION, > + {"track_commit_timestamp", PGC_POSTMASTER, REPLICATION_SENDING, > I can get behind this change for clarity where it gets actively used.
I'm not sure what you meant? ...but, I realized just now that *zero* other GUCs use "REPLICATION". And the documentation puts it in 20.6.1. Sending Servers, so it still seems to me that this is correct to move this, too. https://www.postgresql.org/docs/devel/runtime-config-replication.html Then, I wonder if REPLICATION should be removed from guc_tables.h... -- Justin