On 2021/04/26 13:52, Bharath Rupireddy wrote:
On Fri, Apr 23, 2021 at 9:50 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
Thanks for the review! I fixed this.
Thanks for the updated patches.
In docs v4 patch, I think we can combine below two lines into a single line:
+ supported by the foreign data wrapper,
see <xref linkend="postgres-fdw"/>.
You mean "supported by the foreign data wrapper <xref linkend="postgres-fdw"/>"?
I was thinking that it's better to separate them because postgres_fdw
is just an example of the foreign data wrapper supporting TRUNCATE.
This makes me think again; isn't it better to add "for example" or
"for instance" into after "data wrapper"? That is,
<command>TRUNCATE</command> can be used for foreign tables if
supported by the foreign data wrapper, for instance,
see <xref linkend="postgres-fdw"/>.
Other than the above minor change, both patches look good to me, I
have no further comments.
Thanks! I pushed the patch
truncate_foreign_table_dont_pass_only_clause_xx.patch, at first.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
