Hello Amit, On 2021-Apr-26, Amit Langote wrote:
> On Sat, Apr 24, 2021 at 8:31 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > I haven't added a mechanism to verify this; but with asserts on, this > > patch will crash if you have more than one. I think the behavior is not > > necessarily sane with asserts off, since you'll get an arbitrary > > detach-Xmin assigned to the partdesc, depending on catalog scan order. > > Maybe this is an ignorant question but is the plan to add an elog() in > this code path or a check (and an ereport()) somewhere in > ATExecDetachPartition() to prevent more than one partition ending up > in detach-pending state? Yeah, that's what I'm planning to do. > Please allow me to study the patch a bit more closely and get back tomorrow. Sure, thanks! -- Álvaro Herrera Valdivia, Chile "But static content is just dynamic content that isn't moving!" http://smylers.hates-software.com/2007/08/15/fe244d0c.html