Hi,

I found some possible redundant comments in fmgr.c

1.
fmgr_symbol(Oid functionId, char **mod, char **fn)
{
              HeapTuple          procedureTuple;
              Form_pg_proc procedureStruct;
              bool                     isnull;
              Datum                 prosrcattr;
            Datum                 probinattr;
-             /* Otherwise we need the pg_proc entry */
              procedureTuple = SearchSysCache1(PROCOID, 
ObjectIdGetDatum(functionId));

I guess the comment here was miscopied from fmgr_info_cxt_security:



2.
              if (!HeapTupleIsValid(procedureTuple))
                          elog(ERROR, "cache lookup failed for function %u", 
functionId);
            procedureStruct = (Form_pg_proc) GETSTRUCT(procedureTuple);
-             /*
-             */

Best regards,
houzj


Attachment: 0001-fix-comment-in-fmgr.c.patch
Description: 0001-fix-comment-in-fmgr.c.patch

Reply via email to