On Thu, Apr 22, 2021 at 1:50 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Apr 22, 2021 at 8:26 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > Few comments: > 1. > I think we want stats collector to not use pgStatLocalContext unless > it has read the stats file similar to other cases. So probably, we > should allocate it in pgStatLocalContext when we read 'R' message in > pgstat_read_statsfiles. Also, the function pgstat_get_replslot_entry > should not use pgStatLocalContext to allocate the hash table.
Agreed. > 2. > + if (replSlotStatHash != NULL) > + (void) hash_search(replSlotStatHash, > + (void *) &(msg->m_slotname), > + HASH_REMOVE, > + NULL); > > Why have you changed this part from using NameStr? I thought that since the hash table is created with the key size sizeof(NameData) it's better to use NameData for searching as well. > 3. > +# Check that replicatoin slot stats are expected. > > Typo. replicatoin/replication Will fix in the next version. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
