On Tue, Apr 20, 2021 at 2:47 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Mon, Apr 19, 2021 at 2:55 PM Andrew Dunstan <and...@dunslane.net> wrote: > > There are at least two other client side programs in contrib. So this > > argument doesn't quite hold water from a consistency POV. > > I thought that at first, too. But then I realized that those programs > are oid2name and vacuumlo. And oid2name, at least, seems like > something we ought to just consider removing. It's unclear why this is > something that really deserves a command-line utility rather than just > some additional psql options or something. Does anyone really use it?
Yeah, this seems like it could relatively simply just be a SQL query in psql. > vacuumlo isn't that impressive either, since it makes the very tenuous > assumption that an oid column is intended to reference a large object, > and the documentation doesn't even acknowledge what a shaky idea that > actually is. But I suspect it has much better chances of being useful > in practice than oid2name. In fact, I've heard of people using it and, > I think, finding it useful, so we probably don't want to just nuke it. Yes, I've definitely run into using vacuumlo many times. > But the point is, as things stand today, almost everything in contrib > is an extension, not a binary. And we might want to view the > exceptions as loose ends to be cleaned up, rather than a pattern to > emulate. I could certainly sign up for moving vacuumlo to bin/ and replacing oid2name with something in psql for example. (But yes, I realize this rapidly turns into another instance of the bikeshedding about the future of contrib..) -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
