On Sat, Apr 17, 2021 at 2:04 PM osumi.takami...@fujitsu.com < osumi.takami...@fujitsu.com> wrote:
> > No problem. Thank you for updating the patch. > I've conducted some cosmetic changes. Could you please check this ? > That's already applied by pgindent. > > I executed RT for this and made no failure. > Just in case, I executed 010_truncate.pl test 100 times in a tight loop, > which also didn't fail. > > I reviewed the patch, ran make check, no issues. One minor comment: Could you add the comment similar to RelationGetIndexAttrBitmap() on why the redo, it's not very obvious to someone reading the code, why we are refetching the index list here. + /* Check if we need to redo */ + newindexoidlist = RelationGetIndexList(relation); thanks, Ajin Cherian Fujitsu Australia
