On Mon, Apr 19, 2021 at 12:25 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, Apr 09, 2021 at 06:45:45PM -0400, Alvaro Herrera wrote: > > We forgot this patch earlier in the commitfest. Do people think we > > should still get it in on this cycle? I'm +1 on that, since it's a > > safety feature poised to prevent more bugs than it's likely to > > introduce. > > No objections from here to do that now even after feature freeze. I > also wonder, while looking at that, why you don't just remove the last > call within src/backend/catalog/heap.c. This way, nobody is tempted > to use RelationOpenSmgr() anymore, and it could just be removed from > rel.h.
Agree, did the same in the attached version, thanks. Regards, Amul P.S. commitfest entry https://commitfest.postgresql.org/33/3084/
v2_Add-RelationGetSmgr-inline-function.patch
Description: Binary data
