On Sun, Apr 18, 2021 at 6:51 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > Yes, also the following expectation in expected/stats.out is wrong: > > SELECT slot_name, spill_txns = 0 AS spill_txns, spill_count = 0 AS > spill_count, total_txns > 0 AS total_txns, total_bytes > 0 AS > total_bytes FROM pg_stat_replication_slots; > slot_name | spill_txns | spill_count | total_txns | total_bytes > -----------------+------------+-------------+------------+------------- > regression_slot | f | f | t | t > (1 row) > > We should expect all values are 0. Please find attached the patch. >
Right. Both your and Vignesh's patch will fix the problem but I mildly prefer Vignesh's one as that seems a bit simpler. So, I went ahead and pushed his patch with minor other changes. Thanks to both of you. -- With Regards, Amit Kapila.
