On 2021-Apr-12, Bruce Momjian wrote: > OK, the attached patch renames pg_stat_activity.queryid to 'query_id'. I > have not changed any of the APIs which existed before this feature was > added, and are called "queryid" or "queryId" --- it is kind of a mess. > I assume I should leave those unchanged. It will also need a catversion > bump.
I think it is fine actually. These names appear in structs Query and PlannedStmt, and every single member of those already uses camelCase naming. Changing those to use "query_id" would look out of place. You did change the one in PgBackendStatus to st_query_id, which also matches the naming style in that struct, so that looks fine also. So I'm -1 on Julien's first proposed change, and +1 on his second proposed change (the name of the first argument of pgstat_report_query_id should be query_id). -- Álvaro Herrera Valdivia, Chile
