On Sun, Apr 11, 2021 at 8:57 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Does this patch seem to fix the problem? > > Hmm ... that looks pretty suspicious, I agree, but why wouldn't an > exclusive buffer lock be enough to prevent concurrency with heap_update?
I don't have any reason to believe that using a super-exclusive lock during heap page vacuuming is necessary. My guess is that returning to doing it that way might make the buildfarm green again. That would at least confirm my suspicion that this code is relevant. The super-exclusive lock might have been masking the problem for a long time. How about temporarily committing this patch, just to review how it affects the buildfarm? -- Peter Geoghegan