On Wed, Apr 7, 2021 at 4:20 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Wed, Apr 07, 2021 at 04:00:46PM +0530, Bharath Rupireddy wrote: > > And also, the commit 578b229718 talks about removing "with (oids = > > false)" someday. Is it the time now to remove that and error out with > > "unrecognized parameter "oids""? > > Nope, and I think that it will remain around for some time. Keeping > around the code necessary to silence WITH OIDS has no real maintenance > cost, and removing it could easily break applications. So there is > little gain in cleaning up that, and a lot of potential loss for > users.
I agree to not remove "with (oids = false)". At least shouldn't we fix the "create table ... with (oids = false, oids = false ....)" case, just to be consistent with other options? With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
