On 2021/04/02 11:20, vignesh C wrote:
On Thu, Apr 1, 2021 at 11:18 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
On 2021/04/02 2:18, Jeevan Ladhe wrote:
On Thu, Apr 1, 2021 at 10:20 PM vignesh C <vignes...@gmail.com
<mailto:vignes...@gmail.com>> wrote:
Hi,
While I was reviewing replication slot statistics code, I found one
issue in the data type used for pgstat_report_replslot function
parameters. We pass int64 variables to the function but the function
prototype uses int type. I I felt the function parameters should be
int64. Attached patch fixes the same.
Isn't it better to use PgStat_Counter instead of int64?
Thanks for your comment, the updated patch contains the changes for it.
Thanks for updating the patch! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION