>-----Original Message----- >From: Fujii Masao <masao.fu...@oss.nttdata.com> >Sent: Friday, April 2, 2021 2:39 PM >To: shinya11.k...@nttdata.com; pgsql-hack...@postgresql.org >Subject: Re: Fix pg_checksums progress report > > > >On 2021/04/02 14:23, shinya11.k...@nttdata.com wrote: >> Hi, >> >> I found a problem with the pg_checksums.c. >> >> The total_size is calculated by scanning the directory. >> The current_size is calculated by scanning the files, but the current_size >> does >not include the size of NewPages. >> >> This may cause pg_checksums progress report to not be 100%. >> I have attached a patch that fixes this. > >Thanks for the report and patch! > >I could reproduce this issue and confirmed that the patch fixes it. > >Regarding the patch, I think that it's better to add the comment about why >current_size needs to be counted including new pages.
Thanks for your review. I added a comment to the patch, and attached the new patch. Regards, Shinya Kato
fix_pg_checksums_progress_report_v2.patch
Description: fix_pg_checksums_progress_report_v2.patch
