I think these names need to be more specific.

+typedef enum CompressionId
+{
+        PGLZ_COMPRESSION_ID = 0,
+        LZ4_COMPRESSION_ID = 1
+

CompressionId, PGLZ_COMPRESSION_ID, LZ4_COMPRESSION_ID are also being used by
Andrey's WAL compression patch.  I suggested he use a prefix, but your patch is
also of limited scope (TOAST).

-- 
Justin


Reply via email to