On 3/10/21 5:49 PM, Surafel Temesgen wrote: > hi Ibrar, > thank you for rebasing > > On Mon, Mar 8, 2021 at 9:34 AM Ibrar Ahmed <ibrar.ah...@gmail.com> wrote: > >> >>> Since the get_row_start_time_col_name() and get_row_end_time_col_name() >>> are similar, IMO we can pass a flag to get StartTime/EndTime column name, >>> thought? >>> >>> > For me your option is better. i will change to it in my next > patch if no objection
I have plenty of objection. I'm sorry that I am taking so long with my review. I am still working on it and it is coming soon, I promise. -- Vik Fearing