čt 4. 3. 2021 v 12:32 odesílatel Matthias van de Meent <boekewurm+postg...@gmail.com> napsal: > > On Thu, 4 Mar 2021 at 11:38, Michael Paquier <mich...@paquier.xyz> wrote: > > > > On Thu, Mar 04, 2021 at 12:16:17PM +0530, Bharath Rupireddy wrote: > > > IMO, the phrasing proposed by Justin upthread looks good. It's like this: > > > > > > > + Each backend running <command>ANALYZE</command> will report its > > > > progress in > > > > + the <structname>pg_stat_progress_analyze</structname> view. See > > > > No objections to just go with that. As a new patch set is needed, I > > am switching the CF entry to "Waiting on Author". > > Thanks for all your comments, and sorry for the delayed response. > Please find attached a new version of the patch set, that is rebased > and contains the requested changes: > > 1/3: > Docs: > - on which the COPY command is executed > + on which the COPY command is being executed > Reworded existing commment: > - /* Increment amount of processed tuples and update the progress */ > + /* Increment the number of processed tuples, and report the progress */ > > 2/3: > Docs: > - ... report its progress to ... > + ... report its progress in ... > - report its progress to the >pg_stat_progress_cluster< ... > + report its progress in the >pg_stat_progress_cluster< view ... > > 3/3: > No changes > > I believe that that was the extent of the not-yet-resolved comments > and suggestions.
LGTM, special thanks for taking over the work on initial COPY progress regression tests. > > With regards, > > Matthias van de Meent.
