On 3/3/21 10:47 PM, Tom Lane wrote: > > I had the same problem as Dian of the func.sgml hunk winding up in > the wrong place. I think this is practically inevitable unless the > submitter uses more than 3 lines of context for the diff, because > otherwise the context is just boilerplate that looks the same > everywhere in the function tables. Unless the diff is 100% up to date > so that the line numbers are exactly right, patch is likely to guess > wrong about where to insert the new hunk. We'll just have to be > vigilant about that.
Noted. > I fooled with your test case a bit ... I didn't think it was really > necessary to create and drop a table, when we could just use a VALUES > clause as source of test data. Also you'd forgotten to update the > "descr" description of the function to match the final understanding > of the semantics. Thank you. > Looks good otherwise, so pushed. Thanks! -- Vik Fearing
