On Wed, Mar 3, 2021 at 2:49 PM vignesh C <vignes...@gmail.com> wrote: > > > > On Wed, Mar 3, 2021 at 7:37 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > > > Greg Nancarrow <gregn4...@gmail.com> writes: > > > I've marked this as "Ready for Committer". > > > > I've pushed this after whacking it around a fair amount. A lot of > > that was cosmetic, but one thing that wasn't is that I got rid of the > > proposed "which_primary_host" variable. I thought the logic around > > that was way too messy and probably buggy. Even if it worked exactly > > as intended, I'm dubious that the design intention was good. I think > > it makes more sense just to go through the whole server list again > > without the restriction to standby servers. In particular, that will > > give saner results if the servers' status isn't holding still. > > > > Buildfarm machine crake and conchuela have failed after this commit. > I had checked the failures, crake is failing because of: > Mar 02 21:22:56 ./src/test/recovery/t/001_stream_rep.pl: Variable declared in conditional statement at line 88, column 2. Declare variables outside of the condition. ([Variables::ProhibitConditionalDeclarations] Severity: 5) > I have analyzed and posted a patch at [1] for this. That might fix this problem. > > Conchuela is failing because of: > ok 17 - connect to node standby_1 if mode "standby" and standby_1,primary listed > ack Broken pipe: write( 13, 'SHOW port;' ) at /usr/local/lib/perl5/site_perl/IPC/Run/IO.pm line 549. > ### Stopping node "primary" using mode immediate > # Running: pg_ctl -D /home/pgbf/buildroot/HEAD/pgsql.build/src/test/recovery/tmp_check/t_001_stream_rep_primary_data/pgdata -m immediate stop > waiting for server to shut down... done > > I could not find the exact reason for this failure, I'm checking further on why it is failing. > Thoughts? > > [1] - https://www.postgresql.org/message-id/CALDaNm3L%3DROeb%3D4rKf0XMN0CqrEnn6T%3D-44m4fsDAhcw-%40mail.gmail.com > OUCVA >
At least the first problem seems to possibly be because of: https://www.effectiveperlprogramming.com/2019/07/no-more-false-postfix-lexical-declarations-in-v5-30/ The buildfarm machine crake is using Perl 5.30.3. Regards, Greg Nancarrow Fujitsu Australia
