On Fri, Feb 26, 2021 at 05:16:17PM +0900, Michael Paquier wrote: > Yes, the existing code could mess up with the selection logic if > PGPORT and PGUSER are both specified in an environment, masking the > value of PGUSER, so let's fix that. This is as old as 412893b.
By the way, I can help but wonder why pgbench has such a different handling for the user name, fetching first PGUSER and then looking at the options while most of the other binaries use get_user_name(). It seems to me that we could simplify the handling around "login" without really impacting the usefulness of the tool, no? -- Michael
signature.asc
Description: PGP signature