Dear Wang, Thank you for giving comments! I forgot to write that parse functions imitates libpq's functios, but you understood that immediately. Genius!
> So, I think parse_options() is not need to be refactored.
OK.
> I think we can use the message as same as the message in fe-connect.c:
> > libpq_gettext("end of string reached when looking for matching \"]\" in
> > IPv6 host address in URI: \"%s\"\n"),
The word "URI" is not used in the ECPG docs and source comments, so I removed.
If we want to add, we should define the "URI" in the ECPG context.
> Maybe we can add the expected character, like (expected ':', '/', '?' or ',')
Fixed, but I think ',' is not allowed in the ECPG.
And I did not add URI because the above reason.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
v2-0001-refactor_ecpgconnect.patch
Description: v2-0001-refactor_ecpgconnect.patch
v2-0002-allow-IPv6.patch
Description: v2-0002-allow-IPv6.patch
