On 2/22/21 9:44 AM, Peter Eisentraut wrote: > On 22.05.20 14:32, Peter Eisentraut wrote: >>> As an improvement over the spec, I think the vast majority of people >>> will be using simple true/false values. Can we make that optional? >>> >>> CYCLE f, t SET is_cycle USING path >>> >>> would be the same as >>> >>> CYCLE f, t SET is_cycle TO true DEFAULT false USING path >> >> I was also considering that. It would be an easy change to make. > > This change has been accepted into the SQL:202x draft.
Yay! > Here is a patch for it. This looks good to me, except that you forgot to add the feature stamp. Attached is a small diff to apply on top of your patch to fix that. -- Vik Fearing
diff --git a/src/backend/catalog/sql_features.txt b/src/backend/catalog/sql_features.txt index a24387c1e7..1ab5f685b9 100644 --- a/src/backend/catalog/sql_features.txt +++ b/src/backend/catalog/sql_features.txt @@ -425,6 +425,7 @@ T121 WITH (excluding RECURSIVE) in query expression YES T122 WITH (excluding RECURSIVE) in subquery YES T131 Recursive query YES T132 Recursive query in subquery YES +T133 Enhanced cycle mark values YES T141 SIMILAR predicate YES T151 DISTINCT predicate YES T152 DISTINCT predicate with negation YES
