On Tue, Feb 16, 2021 at 12:07:10PM +0200, Mark Rofail wrote: ... There's some errors in the latest patch:
http://cfbot.cputube.org/mark-rofail.html gram.y:16933:20: error: invalid operands to binary expression ('List' (aka 'struct List') and 'void *') Assert(**reftypes != NULL); Did you mean to write this, before the assignment of NIL ? Assert(reftypes != NULL); Assert(names != NULL); Apparently these Asserts were added last month. The windows build succeeded, but checks failed like: SELECT * FROM FKTABLEFORARRAYGIN WHERE ftest1 @>> 5; ftest1 | ftest2 --------------+-------- - {5} | 1 - {3,5,2,5} | 3 - {3,5,4,1,3} | 5 - {5,1} | 7 - {3,4,5,3} | 10 -(5 rows) +--------+-------- +(0 rows) Would you send an updated patch to address these ? I suggest to generate the patch series with: git format-patch -v2 origin.. -o patch/foreign-key-arrays/ That generates patches with a prefix like 0001, indicating which one goes "first" (and therefore doesn't depend on the others). -- Justin
