At Thu, 18 Feb 2021 16:27:23 +0900, Michael Paquier <mich...@paquier.xyz> wrote in > On Tue, Feb 16, 2021 at 06:14:15PM +0900, Kyotaro Horiguchi wrote: > > The attached is just fixing that. I tried to make it generic but > > didn't find a clean and translatable way. > > > > Also I found that only three cases in the function are excecised by > > make check. > > > > ATT_TABLE : foreign_data, indexing checks > > ATT_TABLE | ATT_FOREIGN_TABLE : alter_table > > ATT_TABLE | ATT_COMPOSITE_TYPE | ATT_FOREIGN_TABLE : alter_table > > > > I'm not sure it's worth the trouble so the attached doesn't do > > anything for that. > > Each sentence needs to be completely separate, as the language > translated to may tweak the punctuation of the set of objects listed, > at least. But you know that already :)
Yeah, I strongly feel that:p As you pointed, the puctuations and the article (for index and others) was that. > If you have seen cases where permission checks show up messages with > an incorrect relkind mentioned, could you add some regression tests > able to trigger the problematic cases you saw and to improve this > coverage? I can add some regression tests to cover all the live cases. That could reveal no-longer-used combinations. I'll do that. Thaks for the suggestion. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
