On Thu, 18 Feb 2021 at 02:13, Cary Huang <cary.hu...@highgo.ca> wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: tested, passed > > Hi, > > thanks for the patch, however I don't think it is a typo. The comment > indicates a technique that is used throughout many functions in walsender.c, > which is to fill the send-timestamp as late as possible so it is more > accurate. This is done by first reserving a spot in the write stream, write > the actual data, and then finally write the current timestamp to the reserved > spot. This technique is used in WalSndWriteData() and also > XLogSendPhysical()... so really it doesn't matter which function name to put > in the comment. >
After review the code. It says "just as it's done in XLogSendPhysical", not fill out the sendtime with XLogSendPhysical. My bad. Sorry for the noise. I will close this cf entry. -- Regrads, Japin Li. ChengDu WenWu Information Technology Co.,Ltd.
