The call to heap_page_prune() within lazy_scan_heap() passes a bool
literal ('false') as its fourth argument. But the fourth argument is
of type TransactionId, not bool. This has been the case since the
snapshot scalability work performed by commit dc7420c2c92. Surely
something is amiss here.I also notice some inconsistencies in the heap_page_prune() prototype names vs the corresponding definition names. Might be worth doing something about in passing. -- Peter Geoghegan
