On Mon, Feb 15, 2021 at 10:02 AM Peter Geoghegan <p...@bowt.ie> wrote: > On Sat, Feb 6, 2021 at 7:40 PM Andres Freund <and...@anarazel.de> wrote: > > Looks like a mistake on my part... Probably a rename regex that somehow > > went wrong - I went back and forth on those names way too many > > times. Want me to push the fix? > > Spotted another one: Shouldn't ReadNextFullTransactionId() actually be > called ReadNewFullTransactionId()? Actually, the inverse approach > looks like it produces fewer inconsistencies: you could instead rename > ReadNewTransactionId() to ReadNextTransactionId().
I prefer "next", because that's in the name of the variable it reads, and the variable name seemed to me to have a more obvious meaning. That's why I went for that name in commit 2fc7af5e966. I do agree that it's slightly strange that the 32 and 64 bit versions differ here. I'd vote for renaming the 32 bit version to match...
