Hi,
For index_has_deprecated_collation(),

+   object.objectSubId = 0;

The objectSubId field is not accessed
by do_check_index_has_deprecated_collation(). Does it need to be assigned ?

For RelationGetIndexListFiltered(), it seems when (options &
REINDEXOPT_COLL_NOT_CURRENT) == 0, the full_list would be returned.
This can be checked prior to entering the foreach loop.

Cheers

On Sat, Feb 6, 2021 at 11:20 PM Julien Rouhaud <rjuju...@gmail.com> wrote:

> On Thu, Jan 21, 2021 at 11:12:56AM +0800, Julien Rouhaud wrote:
> >
> > There was a conflict with a3dc926009be8 (Refactor option handling of
> > CLUSTER, REINDEX and VACUUM), so rebased version attached.  No other
> > changes included yet.
>
> New conflict, v3 attached.
>

Reply via email to