Tsunakwa-san, On Mon, Jan 25, 2021 at 1:21 PM tsunakawa.ta...@fujitsu.com <tsunakawa.ta...@fujitsu.com> wrote: > From: Amit Langote <amitlangot...@gmail.com> > > Yes, it can be simplified by using a local join to prevent the update of > > the foreign > > partition from being pushed to the remote server, for which my example in > > the > > previous email used a local trigger. Note that the update of the foreign > > partition to be done locally is a prerequisite for this bug to occur. > > Thank you, I was aware that UPDATE calls ExecInsert() but forgot about it > partway. Good catch (and my bad miss.)
It appears I had missed your reply, sorry. > + PgFdwModifyState *fmstate = resultRelInfo->ri_FdwState ? > + (PgFdwModifyState *) > resultRelInfo->ri_FdwState : > + NULL; > > This can be written as: > > + PgFdwModifyState *fmstate = (PgFdwModifyState *) > resultRelInfo->ri_FdwState; Facepalm, yes. Patch updated. Thanks for the review. -- Amit Langote EDB: http://www.enterprisedb.com
v3-0001-Prevent-FDW-insert-batching-during-cross-partitio.patch
Description: Binary data
