At Wed, 3 Feb 2021 15:46:30 +0200, Heikki Linnakangas <hlinn...@iki.fi> wrote in > On 03/02/2021 15:38, John Naylor wrote: > > On Wed, Feb 3, 2021 at 8:08 AM Heikki Linnakangas <hlinn...@iki.fi > > <mailto:hlinn...@iki.fi>> wrote: > > > > > > Hi, > > > > > > While playing with COPY FROM refactorings in another thread, I noticed > > > corner case where I think backslash escaping doesn't work correctly. > > > Consider the following input: > > > > > > \么.foo > > I've seen multibyte delimiters in the wild, so it's not as outlandish > > as it seems. > > We don't actually support multi-byte characters as delimiters or quote > or escape characters: > > postgres=# copy copytest from 'foo' with (delimiter '么'); > ERROR: COPY delimiter must be a single one-byte character > > > The fix is simple enough, so +1. > > Thanks, I'll commit and backpatch shortly.
I'm not sure the assumption in the second hunk always holds, but that's fine at least with Shift-JIS and -2004 since they are two-byte encoding. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
