On Wed, Jan 20, 2021 at 12:47 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Fair. One possibility, which'd take a few more cycles in libpq but > likely not anything significant, is to replace "could not connect to ..." > with "while connecting to ..." once we're past the connect() per se.
Yeah. I think this is kind of a client-side version of errcontext(), except we don't really have that context formally, so we're trying to figure out how to fake it in specific cases. > > Maybe it would be better if it said: > > > connection to database at socket "/tmp/.s.PGSQL.5432" failed: FATAL: > > database "rhaas" does not exist > > I'd be inclined to spell it "connection to server at ... failed", > but that sort of wording is surely also possible. "connection to server" rather than "connection to database" works for me; in fact, I think I like it slightly better. -- Robert Haas EDB: http://www.enterprisedb.com
