Tomas-san, Zhihong-san,
From: Zhihong Yu <z...@yugabyte.com>
> + if (batch_size <= 0)
> + ereport(ERROR,
> + (errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("%s requires a non-negative integer value",
>
> It seems the message doesn't match the check w.r.t. the batch size of 0.
Ah, "non-negative" should be "positive". The message for the existing
fetch_size should be fixed too. Tomas-san, could you include this as well?
I'm sorry to trouble you.
> + int numInserted = numSlots;
>
> Since numInserted is filled by ExecForeignBatchInsert(), the initialization
> can be done with 0.
No, the code is correct, since the batch function requires the number of rows
to insert as input.
Regards
Takayuki Tsunakawa
