On 1/17/21 5:46 PM, Surafel Temesgen wrote: > On Sat, Jan 16, 2021 at 10:12 PM Vik Fearing <v...@postgresfriends.org> > wrote: > >> >> I haven't looked at this patch in a while, but I hope that ALTER TABLE t >> ADD SYSTEM VERSIONING is not adding any columns. That is a bug if it does. >> >> > Yes, that is how I implement it. I don't understand how it became a bug?
This is not good, and I see that DROP SYSTEM VERSIONING also removes these columns which is even worse. Please read the standard that you are trying to implement! I will do a more thorough review of the functionalities in this patch (not necessarily the code) this week. -- Vik Fearing