> > I think this patch should be about a tenth the size. Try modeling it > > on the T_SubscriptingRef-etc case, ie, use ece_generic_processing and > > then ece_evaluate_expr to cover the generic cases. OpExpr is common > > enough to deserve specially optimized code, but NullIf isn't, so shorter > is better. > > Thanks for the review. > > Attaching v2 patch , which followed the suggestion to use > ece_generic_processing and ece_evaluate_expr to simplify the code. > > Please have a check.
Sorry, I found the code still be simplified better. Attaching the new patch. Best regards, houzj
v2_1-0001-add-nullif-case-for-eval_const_expressions.patch
Description: v2_1-0001-add-nullif-case-for-eval_const_expressions.patch
